Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct typo in Factory builder #2507

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix: Correct typo in Factory builder #2507

merged 1 commit into from
Jan 28, 2025

Conversation

sds
Copy link
Member

@sds sds commented Jan 28, 2025

Why is this change needed?

Typo was breaking tests.

Merge Checklist


PR-Codex overview

This PR focuses on updating the use of Factories.Ed25519PPublicKey to Factories.Ed25519PublicKey in test files to ensure consistency and correctness in the handling of public key types.

Detailed summary

  • In apps/hubble/src/storage/db/message.test.ts, changed Factories.Ed25519PPublicKey.build() to Factories.Ed25519PublicKey.build() in a test case.
  • In packages/core/src/validations.test.ts, updated Factories.Ed25519PPublicKey.build() to Factories.Ed25519PublicKey.build() in two instances where a message is created for validation testing.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 9:58pm

Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: 47ab783

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@sanjayprabhu sanjayprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sanjayprabhu sanjayprabhu enabled auto-merge (squash) January 28, 2025 22:00
@sanjayprabhu sanjayprabhu merged commit 73d5dac into main Jan 28, 2025
7 checks passed
@sanjayprabhu sanjayprabhu deleted the sds/fix-typo branch January 28, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants