chore: Move release images to quay.io #5047
Open
+47
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchughesiv
force-pushed
the
quayImages
branch
3 times, most recently
from
ce542e5 to
7d057b9
Compare
Signed-off-by: Tommy Hughes <[email protected]>
tchughesiv
force-pushed
the
quayImages
branch
from
7d057b9 to
ec64faf
Compare
|
@franciscojavierarceo we might want to wait until right before the next release to merge this... as it will break the existing |
|
Any change required for root Makefile-> https://github.com/feast-dev/feast/blob/master/Makefile#L531 |
|
@redhatHameed no, everything is defined via CI w/ the |
Thanks, make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Moving release image to quay.io. With this PR, I've tried to change all necessary CI and image references.
In order for the image pushes to succeed, we'll need the following secrets added to this GH repo's settings.
At the same time, we'll want to delete the following existing secrets -
Which issue(s) this PR fixes:
Fixes #5046