Detailed logs for base producer poll error events #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Maintainers,
We have a number of mystery logs in our systems using rust-rdkafka along the lines of:
Ignored event 'Error' on base producer pollI created this simple branch to get the error details out so we could diagnose and fix. The issue was fairly simple in the end (idle connections were being closed by AWS LBs, recommended settings for
connections.max.idle.mswere missing). It would be great if I could get this (or similar) into a release someday to help us diagnose this kind of issue in the future.I can see that this change could subtly impact current users as new error events will be pushed through
ClientContext::error. If that's considered acceptable and manageable then great. Alternatively could have pushed the error detail throughClientContext::logwhich feels like it's less likely to cause issue although it's a little unsymmetrical?Any thoughts and help getting this in would be greatly appreciated.