Drop query to PDC #583
Drop query to PDC #583
Conversation
|
Build succeeded. ✔️ fi-tox-mypy SUCCESS in 5m 45s |
|
Build succeeded. ✔️ fi-tox-mypy SUCCESS in 12m 01s |
docs/ca-design.rst
Outdated
| @@ -253,9 +253,9 @@ defined in use cases layer. | |||
| Class that is checking if the package is newer or not than the package currently available | |||
| in Fedora using mdapi system. Inherits from `validator.py`. | |||
|
|
|||
| * **pdc.py** | |||
| * **retired.py** | |||
There was a problem hiding this comment.
There should be one validator per external system (it makes it easier to replace them when needed). In this case it would be better to update the Pagure validator and add a new key retired to output dictionary.
There was a problem hiding this comment.
Added retired as a new key in the output dictionary under the pagure validator.
But I'm not too happy about having two request calls in one function. It complicates the testing and does not feel right. I'll try to figure out how to make it better.
|
The implementation should be different and adhere to original design. One external system per one validator. Also the news file is missing. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Signed-off-by: Lenka Segura <[email protected]>
Signed-off-by: Lenka Segura <[email protected]>
|
Ah, yes, and the news file. Changing this PR to draft for now. |
|
Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci ✔️ fi-tox-mypy SUCCESS in 6m 17s |
|
Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci ✔️ fi-tox-mypy SUCCESS in 7m 35s |
|
Build succeeded. ✔️ fi-tox-mypy SUCCESS in 8m 27s |
|
Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci ✔️ fi-tox-mypy SUCCESS in 12m 51s |
|
Formatting fails on black failure to reformat a file with |
|
Mmm...python 38 and 39 are also not happy about case matching... |
|
Build succeeded. ✔️ fi-tox-mypy SUCCESS in 11m 21s |
|
Build succeeded. ✔️ fi-tox-mypy SUCCESS in 10m 53s |
Signed-off-by: Lenka Segura <[email protected]>
|
Build succeeded. ✔️ fi-tox-mypy SUCCESS in 11m 05s |
Signed-off-by: Lenka Segura <[email protected]>
|
Build succeeded. ✔️ fi-tox-mypy SUCCESS in 11m 11s |
Remove PDC calls from the-new-hotness.
PDC was used when checking if a package is retired. Now it is checked on dist-git.
Module
pdc.pyrenamed toretired.py. I'm not sure if it's the best approach, since the other modules are named after the app they are calling, but naming itdist-gitfor example might be confusing, since there is apaguremodule which also uses dist-git.Another option would be to add the validator of the retired packages as a method of the
pagureclass. That would need wider changes in the code I think, but it's doable :)