Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean hub tags #1468

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Clean hub tags #1468

merged 2 commits into from
Jan 28, 2025

Conversation

mikkelhegn
Copy link
Member

Fix #1354

Signed-off-by: Mikkel Mørk Hegnhøj <[email protected]>
@mikkelhegn mikkelhegn requested a review from macolso January 24, 2025 14:36
content/api/hub/sample_jinja2.md Outdated Show resolved Hide resolved
content/api/hub/sample_spin_wordle.md Outdated Show resolved Hide resolved
@itowlson
Copy link
Contributor

CI failures are spurious and fixed in another PR

@mikkelhegn
Copy link
Member Author

@itowlson - I struggled a bit with this, so wanted to be sure we're on the same page here. These are the tags shown on the cards, and are not what's use for filtering (through the left hand-side menu).

These are part of the search index, together with keywords and tags (which are the left-hand filters).

I think there's a consolidation potential to not have both tags and keywords, but just one of them. I'll link this PR to this issue to track that: #862

image

Signed-off-by: Mikkel Mørk Hegnhøj <[email protected]>
@mikkelhegn mikkelhegn requested a review from itowlson January 27, 2025 10:04
@itowlson
Copy link
Contributor

Yes, that is my understanding, and I agree that we should review whether the separation is useful. The fact that you can't click on tags, and that tags don't contribute to search, is surprising to me. But that's definitely a separate issue (and thanks for raising something to track it).

@mikkelhegn mikkelhegn merged commit 89a4d13 into fermyon:main Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean up tags for each template/sample on the spin up hub
2 participants