Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Replace static instance in App with DI #13382

Closed
wants to merge 4 commits into from

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Sep 16, 2023

Code Quality: Replace static instance in App with DI

Motivation & Context

  • Improved readability
  • Improved maintainability

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Feature: Improving Performance, optimizations, reliability and codebase  #4180
    Related Code Quality: Continued work to clean up entire project #12340
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

None

@0x5bfa
Copy link
Member Author

0x5bfa commented Sep 17, 2023

Ready for review.

@0x5bfa 0x5bfa closed this Sep 18, 2023
@0x5bfa 0x5bfa deleted the 5bfa/Replace-StaticWithDI branch September 18, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant