Code Quality: Introduced AppThemeModeService

[0x5bfa]

Summary

This is one of the efforts to migrate static Helpers to singleton Services.

Task Checklist

• Introduced AppThemeModeService : IAppThemeModeService
• Removed SettingsViewModel, which had theme changed event handler and has been marked as obslete.

Steps To Validate Changes

1. Launch the app
2. See the sections you have expanded are expanded expectedly
3. Go to Settings dialog
4. Change theme mode
5. See theme will be changed both in main app window and dialog

Known Issues

N/A

PR Checklist

• Development: Related: Code Quality: Improved app theme mode handler #13490
• Approval: Have discussed with and got approval from the team¹
• Tests: Tested accessibility on the local end
• Deployment: Deployed the app on the local end
• Localization: Modified en-US string resources²
• Co-authors: N/A

Screenshots

N/A

Footnotes

1. If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request. ↩

2. If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead. ↩

[yaira2]

Should this be "System"?

[0x5bfa]

I don't have preferences. Would like to rename to System?

[yaira2]

As long as we keep the existing user settings

[yaira2]

Please add comments

[0x5bfa]

I could not figure out why the tests have kept failing though I unintalled, did clean build, did rebuild and the app worked well.