Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainPage MVVM #4161

Merged
merged 10 commits into from
Mar 22, 2021
Merged

MainPage MVVM #4161

merged 10 commits into from
Mar 22, 2021

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Mar 18, 2021

Itemize resolved / related issues by this PR.

Details of Changes
MainPage now follows MVVM pattern.

Validation

How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@d2dyno1 d2dyno1 marked this pull request as ready for review March 22, 2021 09:41
@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 22, 2021

@yaichenbaum @duke7553 Ready!

@d2dyno1 d2dyno1 requested a review from yaira2 March 22, 2021 13:52
@d2dyno1 d2dyno1 requested a review from yaira2 March 22, 2021 13:58
@d2dyno1 d2dyno1 requested a review from yaira2 March 22, 2021 14:30
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 22, 2021
@yaira2 yaira2 merged commit 0292839 into files-community:main Mar 22, 2021
@d2dyno1 d2dyno1 deleted the m_mvvm branch March 25, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants