Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ItemManipulationModel #4471

Merged
merged 6 commits into from
Apr 7, 2021
Merged

Added ItemManipulationModel #4471

merged 6 commits into from
Apr 7, 2021

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Apr 6, 2021

Resolved / Related Issues

Details of Changes
This PR introduces ItemManipulationModel class that contains functions to manipulate BaseLayout items.

Motivation
Use ItemManipulationModel instead of IShellPage.SlimContentPage to later get rid of that reference.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

winston-de
winston-de previously approved these changes Apr 7, 2021
Copy link
Contributor

@winston-de winston-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, great work!

@winston-de winston-de added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 7, 2021
winston-de
winston-de previously approved these changes Apr 7, 2021
@d2dyno1
Copy link
Member Author

d2dyno1 commented Apr 7, 2021

@winston-de Ok, good now! Visual Studio had a seizure.

@yaira2 yaira2 merged commit 4ed28d0 into files-community:main Apr 7, 2021
@d2dyno1 d2dyno1 deleted the imp_cb2 branch April 14, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants