Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define CI_BUILDS_DIR predefined variable #1489

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ANGkeith
Copy link
Collaborator

@ANGkeith ANGkeith commented Feb 2, 2025

No description provided.

@ottok
Copy link
Contributor

ottok commented Feb 16, 2025

Should the git commit message explain why you suggest this change?

I have seen issues with the path but this commit does not convince why defining it like this is the best solution.

@ANGkeith
Copy link
Collaborator Author

ANGkeith commented Feb 17, 2025

Should the git commit message explain why you suggest this change?

We're updating the predefined variable on a best-effort basis, mostly mirroring GitLab's implementation (GitLab Docs). There may not be much to explain beyond that.

but this commit does not convince why defining it like this is the best solution.

yeah, i don't think this is the best solution, we probably need to update
https://github.com/firecow/gitlab-ci-local/blob/master/src/job.ts#L22 accordingly and update CI_BUILDS_DIR -> /builds

@ANGkeith ANGkeith marked this pull request as draft February 17, 2025 13:42
@ottok
Copy link
Contributor

ottok commented Feb 18, 2025

In #1473 I noticed that one needs to pass --variable CI_BUILDS_DIR=/gcl-builds to the command. This PR is likely to fix that, not matter what path you end up choosing, as having that variable defined will make the paths work.

@ANGkeith ANGkeith force-pushed the feat/define-CI_BUILDS_DIR branch from c3250cf to c0dbb06 Compare February 25, 2025 16:20
- update container-executor to use /builds instead of /gcl-builds as CI_BUILDS_DIR
@ANGkeith ANGkeith force-pushed the feat/define-CI_BUILDS_DIR branch from c0dbb06 to a3e6813 Compare February 25, 2025 16:26
@ANGkeith ANGkeith removed the tiny label Feb 25, 2025
@ANGkeith ANGkeith marked this pull request as ready for review February 25, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants