[flang1] Fix compilation warnings; NFCI #1086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the Flang code base so that WITH_WERROR=on can be used at CMake time to enable stricter linting. This patch mainly addresses the following types of warnings: - -Wcast-qual warnings as a result of mixing (char *) fields and parameters with (const char *) values, especially string literals. Most of these can be trivially fixed by changing the type of the fields/parameters in question to (const char *). Tricky cases are handled with explicit casts (e.g. of string literals to (char *)). - -Wunused-variable and -Wsometimes-uninitialized warnings. Unused variables are deleted, and ones that are used conditionally are initialized with sensible defaults. - -Wmissing-field-initializers warnings for partial initializers in data structure definitions. - -Wformat warnings (e.g. "%d" vs. "%ld", "%p" for non-(void *) arguments).
bryanpkc
force-pushed
the
fix-flang1-compilation-warnings
branch
from
5cb4433 to
e939d38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Flang code base so that
WITH_WERROR=oncan be used at CMake time to enable stricter linting. This patch mainly addresses the following types of warnings:-Wcast-qualwarnings as a result of mixingchar *fields and parameters withconst char *values, especially string literals. Most of these can be trivially fixed by changing the type of the fields/parameters in question toconst char *. Tricky cases are handled with explicit casts (e.g. of string literals tochar *).-Wunused-variableand-Wsometimes-uninitializedwarnings. Unused variables are deleted, and ones that are used conditionally are initialized with sensible defaults.-Wmissing-field-initializerswarnings for partial initializers in data structure definitions.-Wformatwarnings (e.g."%d"vs."%ld","%p"for non-void *arguments).This patch depends on previous patches listed in #1065.