Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor export scripts updates #290

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Minor export scripts updates #290

merged 1 commit into from
Feb 23, 2023

Conversation

metachris
Copy link
Collaborator

📝 Summary

  • Environment variables to configure bids BUCKET_SIZE as well as payloads month
  • some GC on exporting bids

✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@metachris metachris requested a review from avalonche February 22, 2023 12:41
avalonche
avalonche reviewed Feb 22, 2023
View reviewed changes
scripts/export-bids.sh
@@ -1,13 +1,13 @@
#!/bin/bash
set -o errexit
set -o nounset
# set -o nounset
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed?

avalonche
avalonche approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@avalonche avalonche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be super useful to document (e.g. as a comment at the start of the script) the available env vars that can be set for the script

@metachris
Copy link
Collaborator Author

agree! hopefully someone could take a stab at it :)

@metachris metachris merged commit 5c95f03 into main Feb 23, 2023
@metachris metachris deleted the exports-scripts-fix branch February 23, 2023 11:12
@metachris
Copy link
Collaborator Author

documented: #292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avalonche avalonche avalonche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metachris @avalonche