-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log timestamps in RFC3339Milli #537
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
==========================================
+ Coverage 33.26% 33.35% +0.09%
==========================================
Files 24 24
Lines 5090 5315 +225
==========================================
+ Hits 1693 1773 +80
- Misses 3178 3318 +140
- Partials 219 224 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Side note: this was discussed at the end of MEV Boost call 6. |
In mev-boost we're using this with millisecond precision: https://github.com/flashbots/mev-boost/blob/develop-deneb/cli/main.go#L223-L234 + https://github.com/flashbots/mev-boost/blob/develop-deneb/config/vars.go#L14 Any reason for nanoseconds over millis? |
(sorry accidentally clicked on close) |
@alextes do you want to rebase and update / engage in the comments? |
i just didn't see any |
d63a389
to
095f817
Compare
- Changes the timestamp format to human-readable RFC3339. - Increases the precision to millisecond from second.
i see now i completely read over your suggestion to use a custom RFC3339Milli format like done in mev-boost if we don't care about nano precision 🙈 . great suggestion, updated the PR. |
📝 Summary
⛱ Motivation and Context
Current log precision is on the second level. On a high volume relay bids are in the hundreds per second, meaning logs, in the thousands, will share the same timestamp and lose their ordering. This would return ordering, and as a bonus make timestamps human-readable.
📚 References
✅ I have run these commands
make lint
make test-race
go mod tidy
CONTRIBUTING.md