Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the
flb_pipe_r
andflb_pipe_w
macros do not set errno on failure, meaning callingflb_errno
in error scenarios is insufficient. This PR adds a new macro that will check the correct place,WSAGetLastError
, and output a similar error message. On Linux this will still beflb_errno
, meaning messages should work the same as they always did, but now on Windows we will get actual error messages.Fixes #3146
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
I had trouble finding a scenario wherein a proper
winsock.h
failure is propagated. In #3146 they mentioned sending to an elasticsearch host that is not available, but the pattern for how the http client handles that error appears to have changed such that a direct pipe read error isn't propagated.To test the log format, I made this local change on Windows:
Resulting log:
On Linux I made the following similar local change:
And this is the resulting error message:
Documentation
Docs PR should not be required.
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.