Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add Ruby 3.3/3.4 for CI #526

Merged
merged 2 commits into from
Mar 4, 2025
Merged

github: add Ruby 3.3/3.4 for CI #526

merged 2 commits into from
Mar 4, 2025

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Feb 6, 2025

No description provided.

@kenhys
Copy link
Contributor Author

kenhys commented Feb 6, 2025

Need to fix for 3.3 or later. it's out-of-scope in this PR.

@kenhys kenhys changed the title github: add Ruby 3.4 for CI github: add Ruby 3.3/3.4 for CI Feb 6, 2025
Signed-off-by: Kentaro Hayashi <[email protected]>
  /opt/hostedtoolcache/Ruby/3.4.2/x64/lib/ruby/gems/3.4.0/gems/ruby-kafka-1.5.0/lib/kafka/protocol/record_batch.rb:1:
  warning: bigdecimal was loaded from the standard library, but is not
  part of the default gems starting from Ruby 3.4.0.  You can add
  bigdecimal to your Gemfile or gemspec to silence this warning.

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys requested review from Watson1978 and daipom March 4, 2025 06:24
Copy link
Contributor

@Watson1978 Watson1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kenhys kenhys merged commit 256b6b0 into master Mar 4, 2025
23 checks passed
@kenhys kenhys deleted the update-ci branch March 4, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants