Move get_keyboard_state from FlKeyboardViewDelegate to FlKeyboardManager. #56021
+180
−217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally the tests would mock FlEngine, but I wasn't able to get it working so I've added fl_keyboard_manager_set_send_key_event_handler for now.
…ger. Like the other associated changes, I've added fl_keyboard_manager_set_get_get_pressed_state_handler for now to keep the tests working.
|
This builds on top of #56020, only the last commit needs review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the other associated changes, I've added fl_keyboard_manager_set_get_get_pressed_state_handler for now to keep the tests working.