Skip to content

Commit

Permalink
Remove resolved todo and fix dartdocs
Browse files Browse the repository at this point in the history
  • Loading branch information
FirentisTFW committed Jan 28, 2025
1 parent 8fc1fa0 commit b745dcc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ class MiniController extends ValueNotifier<VideoPlayerValue> {
Completer<void>? _creatingCompleter;
StreamSubscription<dynamic>? _eventSubscription;

/// The id of a texture that hasn't been initialized.
/// The id of a player that hasn't been initialized.
@visibleForTesting
static const int kUninitializedPlayerId = -1;
int _playerId = kUninitializedPlayerId;
Expand Down Expand Up @@ -424,7 +424,7 @@ class _VideoPlayerState extends State<VideoPlayer> {
void initState() {
super.initState();
_playerId = widget.controller.playerId;
// Need to listen for initialization events since the actual texture ID
// Need to listen for initialization events since the actual player ID
// becomes available after asynchronous initialization finishes.
widget.controller.addListener(_listener);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ import 'package:video_player_platform_interface/video_player_platform_interface.

import 'messages.g.dart';

// TODO(FirentisTFW): Remove the ignore and rename parameters when adding support for platform views.
// ignore_for_file: avoid_renaming_method_parameters

/// An Android implementation of [VideoPlayerPlatform] that uses the
/// Pigeon-generated [VideoPlayerApi].
class AndroidVideoPlayer extends VideoPlayerPlatform {
Expand Down

0 comments on commit b745dcc

Please sign in to comment.