-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google_maps_flutter] improvements to google maps state handling #8431
base: main
Are you sure you want to change the base?
[google_maps_flutter] improvements to google maps state handling #8431
Conversation
f2cf468
to
a20b7f7
Compare
@@ -469,7 +469,6 @@ class _GoogleMapState extends State<GoogleMap> { | |||
this, | |||
); | |||
_controller.complete(controller); | |||
unawaited(_updateTileOverlays()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this as it seems to be unnecessary when the missing widget.tileOverlays is added to the google map. Also this may have cause this issue:
flutter/flutter#43785 (comment)
b8ad73b
to
254f58f
Compare
6f39abd
to
0113dab
Compare
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
FYI this might help with another issue: flutter/flutter#115283 Which has an older attempted fix PR that you might be able to glean something useful from: |
…id and iOS platforms
0113dab
to
5f4c4f3
Compare
Related issue:
flutter/flutter#43785
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.