[webview_flutter] Opt-in feature that javaScript can automatically open window for iOS platform #8505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR aims to add an option that Javascript can open window without user interaction. related issue is flutter/flutter#112276.
Diving into the detail, I added a setter named
setJavaScriptCanOpenWindowsAutomatically
toWebViewController
that can configure javaScriptCanOpenWindowsAutomatically whose default value isfalse
in iOS platform.There are two scenarios when
javaScriptCanOpenWindowsAutomatically
needs to betrue
.setInterval
. Even with user interaction, iOS prevents webview from opening new window in this scenario.In general, first scenario should be prevented but second scenario might be accepted in some cases. This is why I tried to solve this issue.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.