Skip to content

Commit

Permalink
remove unnecessary
Browse files Browse the repository at this point in the history
Signed-off-by: Troy Chiu <[email protected]>
  • Loading branch information
troychiu committed Feb 19, 2025
1 parent 8ba253c commit 8bc2096
Showing 1 changed file with 1 addition and 20 deletions.
21 changes: 1 addition & 20 deletions flytekit/remote/entities.py
Original file line number Diff line number Diff line change
Expand Up @@ -348,33 +348,26 @@ def promote_from_model(cls, model: _workflow_model.GateNode):


class FlyteArrayNode(_workflow_model.ArrayNode):
def __init__(self, node, parallelism, min_successes, min_success_ratio, flyte_task_node=None, flyte_workflow_node=None):
def __init__(self, node, parallelism, min_successes, min_success_ratio, flyte_task_node=None):
super().__init__(node, parallelism, min_successes, min_success_ratio)
self._flyte_task_node = flyte_task_node
self._flyte_workflow_node = flyte_workflow_node

@property
def flyte_task_node(self):
return self._flyte_task_node

@property
def flyte_workflow_node(self):
return self._flyte_workflow_node

@classmethod
def promote_from_model(
cls,
model: _workflow_model.ArrayNode,
flyte_task_node: Optional[FlyteTaskNode] = None,
flyte_workflow_node: Optional[FlyteWorkflowNode] = None,
):
return cls(
node=model._node,
parallelism=model._parallelism,
min_successes=model._min_successes,
min_success_ratio=model._min_success_ratio,
flyte_task_node=flyte_task_node,
flyte_workflow_node=flyte_workflow_node,
)


Expand Down Expand Up @@ -504,18 +497,6 @@ def promote_from_model(
f"Remote Workflow closure does not have task with id {model.array_node.node.task_node.reference_id}."
)
flyte_array_node = FlyteArrayNode.promote_from_model(model.array_node, flyte_task_node=cls._promote_task_node(tasks[model.array_node.node.task_node.reference_id]))
# map over launch plan
elif model.array_node.node.workflow_node is not None:
workflow_node, converted_sub_workflows = cls._promote_workflow_node(
model.array_node.node.workflow_node,
sub_workflows,
node_launch_plans,
tasks,
converted_sub_workflows,
)
flyte_array_node = FlyteArrayNode.promote_from_model(
model.array_node, flyte_workflow_node=workflow_node
)
else:
raise _system_exceptions.FlyteSystemException(
"Array node must have either task or workflow node specified"
Expand Down

0 comments on commit 8bc2096

Please sign in to comment.