Skip to content

Commit

Permalink
update param naming
Browse files Browse the repository at this point in the history
Signed-off-by: Paul Dittamo <[email protected]>
  • Loading branch information
pvditt committed Feb 25, 2025
1 parent d2753ea commit 8ca58fa
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
4 changes: 4 additions & 0 deletions flytekit/core/array_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,10 @@ def execution_mode(self) -> _core_workflow.ArrayNode.ExecutionMode:
def is_original_sub_node_interface(self) -> bool:
return True

@property
def bound_inputs(self) -> Set[str]:
return set()

def __call__(self, *args, **kwargs):
if not self._bindings:
ctx = FlyteContext.current_context()
Expand Down
6 changes: 3 additions & 3 deletions flytekit/models/core/workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ def __init__(
execution_mode=None,
is_original_sub_node_interface=False,
data_mode=None,
fixed_inputs=None,
bound_inputs=None,
) -> None:
"""
TODO: docstring
Expand All @@ -408,7 +408,7 @@ def __init__(
self._execution_mode = execution_mode
self._is_original_sub_node_interface = is_original_sub_node_interface
self._data_mode = data_mode
self._fixed_inputs = fixed_inputs
self._bound_inputs = bound_inputs

@property
def node(self) -> "Node":
Expand All @@ -423,7 +423,7 @@ def to_flyte_idl(self) -> _core_workflow.ArrayNode:
execution_mode=self._execution_mode,
is_original_sub_node_interface=BoolValue(value=self._is_original_sub_node_interface),
data_mode=self._data_mode,
fixed_inputs=self._fixed_inputs,
bound_inputs=self._bound_inputs,
)

@classmethod
Expand Down
2 changes: 1 addition & 1 deletion flytekit/tools/translator.py
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ def get_serializable_array_node(
execution_mode=array_node.execution_mode,
is_original_sub_node_interface=array_node.is_original_sub_node_interface,
data_mode=array_node.data_mode,
fixed_inputs=array_node.fixed_inputs,
bound_inputs=array_node.bound_inputs,
)


Expand Down

0 comments on commit 8ca58fa

Please sign in to comment.