don't override timeout on with_overrides if not specified #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Dittamo <[email protected]>
Code Review Agent Run Status
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3097 +/- ##
===========================================
- Coverage 76.46% 46.74% -29.73%
===========================================
Files 218 203 -15
Lines 22505 21525 -980
Branches 2766 2779 +13
===========================================
- Hits 17209 10062 -7147
- Misses 4483 10967 +6484
+ Partials 813 496 -317 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Paul Dittamo <[email protected]>
pvditt
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Code Review Agent Run #01a35dActionable Suggestions - 3
Review Details
AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
flyte-bot
reviewed
Jan 27, 2025
flytekit/core/node.py
Outdated
| @@ -47,6 +47,8 @@ class Node(object): | |||
| ID, which from the registration step | |||
| """ | |||
|
|
|||
| timeout_override_sentinel = object() | |||
There was a problem hiding this comment.
Consider more explicit sentinel value type
Consider if using object() as a sentinel value is the best approach here. While it works, using a dedicated sentinel class or enum.Enum could provide better type safety and clarity of intent.
Code suggestion
Check the AI-generated fix before applying
import datetime
+import enum
@@ -50,1 +50,4 @@
-timeout_override_sentinel = object()
+class TimeoutSentinel(enum.Enum):
+ NO_OVERRIDE = 'no_override'
+
+timeout_override_sentinel = TimeoutSentinel.NO_OVERRIDE
Code Review Run #01a35d
Is this a valid issue, or was it incorrectly flagged by the Agent?
- it was incorrectly flagged
flyte-bot
reviewed
Jan 27, 2025
flytekit/core/node.py
Outdated
| raise ValueError("timeout should be duration represented as either a datetime.timedelta or int seconds") | ||
| if timeout is not Node.timeout_override_sentinel: | ||
| if timeout is None: | ||
| node_metadata._timeout = 0 |
There was a problem hiding this comment.
Consider using timedelta for timeout value
Consider using datetime.timedelta() instead of 0 for timeout value to maintain consistency with the type system and other code paths.
Code suggestion
Check the AI-generated fix before applying
Suggested change
| node_metadata._timeout = 0 | |
| node_metadata._timeout = datetime.timedelta() |
Code Review Run #01a35d
Is this a valid issue, or was it incorrectly flagged by the Agent?
- it was incorrectly flagged
There was a problem hiding this comment.
@pvditt For typing, I think this needs to be a timedelta object.
flyte-bot
reviewed
Jan 27, 2025
thomasjpfan
reviewed
Jan 27, 2025
thomasjpfan
reviewed
Jan 28, 2025
Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
Code Review Agent Run #7ddfdbActionable Suggestions - 0Review Details
AI Code Review powered by |
Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
eapolinario
approved these changes
Feb 24, 2025
Code Review Agent Run #7f6c33Actionable Suggestions - 0Additional Suggestions - 10
Review Details
AI Code Review powered by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
fixes: flyteorg/flyte#6153
Why are the changes needed?
with_overrides set timeout to default of 0 if timeout param is not specified
What changes were proposed in this pull request?
How was this patch tested?
added unit tests
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This PR addresses multiple improvements: 1) Fixes a critical bug in with_overrides() method's timeout handling by introducing TIMEOUT_OVERRIDE_SENTINEL for better timeout case management, 2) Implements enhanced error handling and security improvements for private keys and webhooks, 3) Adds proper validation for shared memory formats and improves event loop management, 4) Includes comprehensive test coverage for all changes.Unit tests added: True
Estimated effort to review (1-5, lower is better): 5