-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use uv in all docker images #3137
Conversation
Signed-off-by: Eduardo Apolinario <[email protected]>
Code Review Agent Run #e1ebaeActionable Suggestions - 2
Additional Suggestions - 1
Review Details
|
Changelist by BitoThis pull request implements the following key changes.
|
Signed-off-by: Eduardo Apolinario <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3137 +/- ##
==========================================
- Coverage 92.24% 91.16% -1.08%
==========================================
Files 118 87 -31
Lines 4991 3872 -1119
==========================================
- Hits 4604 3530 -1074
+ Misses 387 342 -45 ☔ View full report in Codecov by Sentry. |
Code Review Agent Run #e8c63fActionable Suggestions - 0Additional Suggestions - 1
Review Details
|
Tracking issue
NA
Why are the changes needed?
We should standardize and use
uv
as much as we can.What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This PR implements two major changes: 1) Standardizes package installation across Docker images using 'uv' package installer with Python 3.12 as default, though reviewers suggest using pip's native features instead. 2) Enhances Flyte plugins by standardizing output handling in AWS SageMaker and OpenAI plugins with LiteralMap format, while improving Ray plugin configuration with better head node handling.Unit tests added: True
Estimated effort to review (1-5, lower is better): 2