Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uv in all docker images #3137

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Use uv in all docker images #3137

merged 2 commits into from
Feb 27, 2025

Conversation

eapolinario
Copy link
Collaborator

@eapolinario eapolinario commented Feb 15, 2025

Tracking issue

NA

Why are the changes needed?

We should standardize and use uv as much as we can.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This PR implements two major changes: 1) Standardizes package installation across Docker images using 'uv' package installer with Python 3.12 as default, though reviewers suggest using pip's native features instead. 2) Enhances Flyte plugins by standardizing output handling in AWS SageMaker and OpenAI plugins with LiteralMap format, while improving Ray plugin configuration with better head node handling.

Unit tests added: True

Estimated effort to review (1-5, lower is better): 2

Signed-off-by: Eduardo Apolinario <[email protected]>
@flyte-bot
Copy link
Contributor

flyte-bot commented Feb 15, 2025

Code Review Agent Run #e1ebae

Actionable Suggestions - 2
  • plugins/flytekit-sqlalchemy/Dockerfile - 1
    • Consider using no-deps flag with uv · Line 11-17
  • plugins/flytekit-flyteinteractive/Dockerfile - 1
Additional Suggestions - 1
  • plugins/flytekit-spark/Dockerfile - 1
Review Details
  • Files reviewed - 4 · Commit Range: 8c909ce..8c909ce
    • plugins/flytekit-flyteinteractive/Dockerfile
    • plugins/flytekit-openai/Dockerfile.batch
    • plugins/flytekit-spark/Dockerfile
    • plugins/flytekit-sqlalchemy/Dockerfile
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

AI Code Review powered by Bito Logo

@flyte-bot
Copy link
Contributor

flyte-bot commented Feb 15, 2025

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Feature Improvement - Standardize Package Installation with UV

Dockerfile - Added uv package installer for dependency management

Dockerfile.batch - Set Python 3.12 as default and implemented uv for package installation

Dockerfile - Integrated uv package installer for Spark plugin dependencies

Dockerfile - Updated to Python 3.12 and restructured package installation using uv

@eapolinario eapolinario enabled auto-merge (squash) February 18, 2025 22:50
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.16%. Comparing base (80ddcda) to head (76a9b3b).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3137      +/-   ##
==========================================
- Coverage   92.24%   91.16%   -1.08%     
==========================================
  Files         118       87      -31     
  Lines        4991     3872    -1119     
==========================================
- Hits         4604     3530    -1074     
+ Misses        387      342      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flyte-bot
Copy link
Contributor

flyte-bot commented Feb 19, 2025

Code Review Agent Run #e8c63f

Actionable Suggestions - 0
Additional Suggestions - 1
  • plugins/flytekit-ray/flytekitplugins/ray/task.py - 1
    • Consider excluding additional Python cache directories · Line 95-95
Review Details
  • Files reviewed - 6 · Commit Range: 8c909ce..76a9b3b
    • plugins/flytekit-aws-sagemaker/flytekitplugins/awssagemaker_inference/boto3_agent.py
    • plugins/flytekit-aws-sagemaker/tests/test_boto3_agent.py
    • plugins/flytekit-openai/flytekitplugins/openai/batch/agent.py
    • plugins/flytekit-openai/tests/openai_batch/test_agent.py
    • plugins/flytekit-ray/flytekitplugins/ray/task.py
    • plugins/flytekit-ray/tests/test_ray.py
  • Files skipped - 3
    • .github/workflows/build_image.yml - Reason: Filter setting
    • .github/workflows/pythonbuild.yml - Reason: Filter setting
    • .github/workflows/pythonpublish.yml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

AI Code Review powered by Bito Logo

@eapolinario eapolinario merged commit 78cb65e into master Feb 27, 2025
108 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants