Fix test_invalid_ge_schema_batchrequest_pandas_config #3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Code Review Agent Run #ef462dActionable Suggestions - 2
Review Details
AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
flyte-bot
reviewed
Feb 19, 2025
flyte-bot
reviewed
Feb 19, 2025
Signed-off-by: Kevin Su <[email protected]>
pingsutw
commented
Feb 19, 2025
| @@ -1532,7 +1532,6 @@ async def _literal_map_to_kwargs( | |||
| raise TypeTransformerFailedError( | |||
| f"Error converting input '{k}' at position {i}:\n" | |||
| f"Literal value: {lm.literals[k]}\n" | |||
| f"Literal type: {literal_types}\n" | |||
There was a problem hiding this comment.
We can remove it since it's None in most cases, and the Python type should be sufficient
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3145 +/- ##
==========================================
- Coverage 92.24% 83.58% -8.66%
==========================================
Files 118 3 -115
Lines 4991 195 -4796
==========================================
- Hits 4604 163 -4441
+ Misses 387 32 -355 ☔ View full report in Codecov by Sentry. |
Code Review Agent Run #0e796cActionable Suggestions - 1
Review Details
AI Code Review powered by |
flyte-bot
reviewed
Feb 19, 2025
Future-Outlier
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
Fix test_invalid_ge_schema_batchrequest_pandas_config unit test
How was this patch tested?
unit test
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This PR enhances error handling mechanisms and test execution efficiency. Key changes include updating exception types in Great Expectations schema testing (from InvalidBatchRequestError to TypeTransformerFailedError), improving error message clarity, and adjusting remote execution test timeout from 10 to 5 minutes. These modifications aim to improve test performance and error specificity while enhancing debugging capabilities.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1