Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add httpx dependency for webhook agent in flytekit dependency #3158

Merged
merged 10 commits into from
Feb 27, 2025
Merged

add httpx dependency for webhook agent in flytekit dependency #3158

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2ad2f28
add httpx dependency for webhook agent in default flytekit
Future-Outlier Feb 26, 2025
75999fc
update
Future-Outlier Feb 27, 2025
11cbaa3
Merge branch 'new-webhook' into add-httpx-in-flytekit-for-webhook
Future-Outlier Feb 27, 2025
f3e4aa7
update
Future-Outlier Feb 27, 2025
4dfd84d
lint
Future-Outlier Feb 27, 2025
c3296c0
update
Future-Outlier Feb 27, 2025
5e2952b
update
Future-Outlier Feb 27, 2025
6dd067e
update
Future-Outlier Feb 27, 2025
e00bab3
update
Future-Outlier Feb 27, 2025
d4a7398
Merge branch 'master' into add-httpx-in-flytekit-for-webhook
Future-Outlier Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion flytekit/clis/sdk_in_container/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,12 @@ def agent(_: click.Context, port, prometheus_port, worker, timeout, modules):
"""
import asyncio

from flytekit.extras.webhook import WebhookTask # noqa: F401
try:
from flytekit.extras.webhook import WebhookTask # noqa: F401
except ImportError:
from flytekit import logger

logger.debug("Webhook is not installed. Please install it using `pip install flytekit[agent]`")

working_dir = os.getcwd()
if all(os.path.realpath(path) != working_dir for path in sys.path):
Expand Down
5 changes: 5 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,3 +147,8 @@ extend-exclude = ["tests/", "**/tests/**"]
[tool.codespell]
ignore-words-list = "ot,te,raison,fo,lits,assertIn"
skip = "./docs/build,./.git,*.txt"

[project.optional-dependencies]
agent = [
"httpx",
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding version constraints for dependencies

Consider adding version constraints to the httpx dependency in the optional dependencies section. This helps ensure compatibility and reproducible builds.

Code suggestion
Check the AI-generated fix before applying
Suggested change
"httpx",
]
"httpx>=0.24.0",
]

Code Review Run #bddc3a

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

  • Yes, avoid them

Loading