Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(starknet): remove some debug print #472

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

ptisserand
Copy link
Collaborator

@ptisserand ptisserand commented Feb 24, 2025

  • Remove some debug print
  • Fix some linter issues

Summary by CodeRabbit

  • Refactor
    • Improved internal stability and consistency by making key variables immutable and aligning formatting to standard guidelines.
  • Chore
    • Removed redundant logging output to streamline background processes without affecting app functionality.

Copy link

docs-page bot commented Feb 24, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/focustree/starknet.dart~472

Documentation is deployed and generated using docs.page.

Copy link
Contributor

coderabbitai bot commented Feb 24, 2025

Walkthrough

The pull request updates the BaseAccountSigner class by declaring several variables as final, ensuring they remain immutable after initialization. It also adjusts the formatting of closing parentheses in specific method calls to align with the Dart style guide. Additionally, a line that printed transaction receipts in the waitForState function of the util.dart file has been removed. These changes improve code clarity and maintainability without impacting the underlying functionality or control flow.

Changes

File Change Summary
packages/starknet/lib/src/account/signer/... Updated variables (l1GasMaxAmount, l1GasMaxPricePerUnit, l2GasMaxAmount, l2GasMaxPricePerUnit, l1GasBounds, l2GasBounds, dataAvailabilityMode) to final;
Adjusted closing parentheses formatting in signInvokeTransactionsV1, signInvokeTransactionsV3, and signDeployAccountTransactionV3 methods.
packages/starknet/lib/src/util.dart Removed the stdout.writeln(receipt); line in the waitForState function, which previously printed the transaction receipt to standard output.

Sequence Diagram(s)

Poem

I’m a rabbit coding through the night,
With final words making variables just right,
Parentheses aligned in a neat parade,
And logging steps quietly evanesced away,
Hop along, dear code, on your refined runway! 🥕


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d2ca640 and 8b9810f.

📒 Files selected for processing (2)
  • packages/starknet/lib/src/account/signer/base_account_signer.dart (7 hunks)
  • packages/starknet/lib/src/util.dart (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/starknet/lib/src/util.dart
✅ Files skipped from review due to trivial changes (1)
  • packages/starknet/lib/src/account/signer/base_account_signer.dart
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: analyze
  • GitHub Check: test-integration
  • GitHub Check: lint

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ptisserand ptisserand merged commit 2db98e4 into focustree:main Feb 24, 2025
10 checks passed
@ptisserand ptisserand deleted the fix/remove-some-debug-print branch February 24, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant