Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport call number browse refactor to v4.0.10 #762

Open
wants to merge 18 commits into
base: release/v4.0
Choose a base branch
from
Open

Backport call number browse refactor to v4.0.10 #762

wants to merge 18 commits into from
+4,028 −1,988

Conversation

viacheslavkol
Copy link
Contributor

@viacheslavkol viacheslavkol commented Mar 4, 2025 •
edited
Loading

Purpose

Backport call number browse refactor to v4.0.10, release v4.0.10

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MSEARCH-959

viacheslavkol and others added 14 commits March 4, 2025 14:42
@viacheslavkol
feat(cn-browse): Implement call number browse config (#703)
9a29704 
* feat(cn-browse): Implement call number browse config

- Populate default call number browse configs in db
- Update browse config endpoints
- Implement call number type events consumer

Implements: MSEARCH-863

(cherry picked from commit 21cecb8)
@psmagin @viacheslavkol
feat(cn-browse): Implement Database Structure and Logic for Managing …
012140b 
…Call Numbers (#702)

Closes: MSEARCH-862

(cherry picked from commit 5cadf05)
@psmagin @viacheslavkol
feat(cn-browse): Implement Indexing and Re-indexing Mechanisms for Ca…
30e5e9f 
…ll-Numbers (#707)

Closes: MSEARCH-864
(cherry picked from commit 24bae72)
@psmagin @viacheslavkol
feat(cn-browse): Implement browsing endpoint for Call Numbers (#712)
8640da1 
Closes: MSEARCH-865
(cherry picked from commit b1bb502)
@viacheslavkol
fix(browse): Fix identifier types limit for browse config (#706)
98937a3 
* fix(browse): Fix identifier types limit for browse config

- Change type_id column type from varchar to array in browse config database table
- Migrate existing type ids

Closes: MSEARCH-890

(cherry picked from commit 120107f)
@SvitlanaKovalova1 @viacheslavkol
fix(cn-browse): adjust logic to scheduled sub-resource indexing (#729)
098c606 
(cherry picked from commit 891c871)
@psmagin @viacheslavkol
fix(cn-browse): adjust populating shared field to be based on instanc…
c04ca59 
…e tenant id

Closes: MSEARCH-939
(cherry picked from commit 29f62aa)
@psmagin @viacheslavkol
fix log level for dev properties
87772d9 
(cherry picked from commit e4df3f8)
@psmagin @viacheslavkol
feat(cn-browse): support aliases for callNumberTypeId filters (#733)
b3a693c 
Closes: MSEARCH-942
(cherry picked from commit 4ca30f7)
@psmagin @viacheslavkol
feat(cn-browse): handle deletes/updates of call-numbers (#734)
d0bbda8 
Closes: MSEARCH-940
(cherry picked from commit 0605e0c)
@psmagin @viacheslavkol
feat(cn-browse): update order of call number components in fullCallNu…
6eed6a5 
…mber (#737)

Closes: MSEARCH-949
(cherry picked from commit 575beae)
@psmagin @viacheslavkol
feat(cn-browse): support showing instance title in browse results list (
a4f2fda 
#739)

Closes: MSEARCH-948
(cherry picked from commit 178ee3c)
@psmagin @viacheslavkol
feat(cn-browse): showing one line in results list regardless of copy …
abf3b04 
…or enumeration data (#740)

Closes: MSEARCH-950
(cherry picked from commit 0f59a9e)
@psmagin @viacheslavkol
feat(cn-browse): add support for `item.effectiveCallNumberComponents.…
ac1e113 
…typeId` search option.

(cherry picked from commit ad5e30b)
@viacheslavkol viacheslavkol self-assigned this Mar 4, 2025
viacheslavkol and others added 4 commits March 4, 2025 17:35
@viacheslavkol
Fix tests, update NEWS
cb0f192
@viacheslavkol
Fix changelog, test mock
02b196e
@psmagin @viacheslavkol
fix(cn-browse): fix permissions
a23dbbc
@viacheslavkol
fix(reindex): Fix issue with using member tenant postgres schema on r…
61cc714 
…eindexing (#746)

* fix(reindex): Fix issue with using member tenant postgres schema on reindexing

- Add user tenants cache eviction on full reindex service call

Closes: MSEARCH-957

(cherry picked from commit d6a3a99)
@viacheslavkol viacheslavkol changed the title Tmp release v4.0.10 Backport call number browse refactor to v4.0.10 Mar 5, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@viacheslavkol viacheslavkol marked this pull request as ready for review March 5, 2025 14:21
@viacheslavkol viacheslavkol requested a review from a team as a code owner March 5, 2025 14:21
@viacheslavkol viacheslavkol requested review from psmagin, mukhiddin-yusuf and SvitlanaKovalova1 and removed request for a team March 5, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psmagin psmagin psmagin approved these changes

@mukhiddin-yusuf mukhiddin-yusuf Awaiting requested review from mukhiddin-yusuf mukhiddin-yusuf is a code owner automatically assigned from folio-org/spitfire-backend

@SvitlanaKovalova1 SvitlanaKovalova1 Awaiting requested review from SvitlanaKovalova1 SvitlanaKovalova1 is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

@viacheslavkol viacheslavkol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viacheslavkol @psmagin @SvitlanaKovalova1