Introduced by-name deployment and declare-deploy command
#2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integraledelebesgue
requested review from
Arcticae,
ksew1 and
tomek0123456789
as code owners
integraledelebesgue
requested review from
Arcticae
and removed request for
Arcticae
Arcticae
requested changes
Jul 30, 2024
cptartur
requested changes
Jul 31, 2024
cptartur
reviewed
Sep 23, 2024
crates/sncast/src/main.rs
Outdated
Comment on lines
225
to
240
| let deploy: DeployResolved = if deploy.class_hash.is_some() { | ||
| deploy.try_into().unwrap() | ||
| } else { | ||
| let contract = | ||
| deploy.build_artifacts_and_get_compiled_contract(cli.json, &cli.profile)?; | ||
| let class_hash = contract.sierra_class_hash; | ||
|
|
||
| if !contract.is_declared(&provider).await? { | ||
| bail!("Contract with class hash {:x} is not declared", class_hash); | ||
| } | ||
|
|
||
| deploy.resolved_with_class_hash(class_hash) | ||
| }; | ||
|
|
||
| deploy.validate()?; | ||
|
|
There was a problem hiding this comment.
So now we will explicitly fail if user tries to deploy contract that wasn't declared? What was the previous behavior. This might be worth including in a changelog if this behavior changed.
There was a problem hiding this comment.
No, the behavior remains the same, e.g. running
sncast -a my_account deploy --class-hash 0x123 --fee-token strk --url http://127.0.0.1:5050will produce
Error: An error occurred in the called contract = ContractErrorData { revert_error: "Class with hash 0x123 is not declared" }which is same as current behavior.
franciszekjob
force-pushed
the
integraledelebesgue/feature-2279
branch
from
61e8f2a to
b11b1bc
Compare
kkawula
reviewed
Dec 16, 2024
franciszekjob
removed request for
ksew1,
tomek0123456789,
Arcticae,
ddoktorski and
franciszekjob
… into integraledelebesgue/feature-2279
… into integraledelebesgue/feature-2279
franciszekjob
requested review from
ksew1,
kkawula,
franciszekjob and
cptartur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2279
Introduced changes
sncast deploynow allows to deploy a contract by its name instead of class hash;--contract-nameand--class-hasharguments are mutually exclusivedeclare-deploy, used to quickly combine declaration with deploymentdeclare,declare-deploy- alwaysdeploy- when depolying by nameChecklist
CHANGELOG.md