Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rpc url optional for show-config command #2701

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Make rpc url optional for show-config command #2701

merged 1 commit into from
Nov 25, 2024

Conversation

ddoktorski
Copy link
Contributor

Closes #2644

Introduced changes

  • Do not require rpc url for show-config command to work
  • Added missing show_explorer_links field to the ShowConfigResponse

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@ddoktorski ddoktorski enabled auto-merge November 25, 2024 16:33
@ddoktorski ddoktorski added this pull request to the merge queue Nov 25, 2024
Merged via the queue into master with commit 6578e28 Nov 25, 2024
26 checks passed
@ddoktorski ddoktorski deleted the 2644-show-config-make-rpc-url-optional branch November 25, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur approved these changes

@kkawula kkawula Awaiting requested review from kkawula kkawula is a code owner

@franciszekjob franciszekjob Awaiting requested review from franciszekjob franciszekjob is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running show-config w/o profile or full sncast yields uninformative result
2 participants
@ddoktorski @cptartur