Validate max gas is greater than zero for strk fee settings

crates/sncast/src/helpers/fee.rs

@@ -91,13 +91,20 @@ impl FeeArgs {
                     {
                         bail!("--max-fee should be greater than or equal to --max-gas-unit-price")
                     }
-                    (None, _, _) => FeeSettings::Strk {
-                        max_gas: self.max_gas.map(TryIntoConv::try_into_).transpose()?,
-                        max_gas_unit_price: self
-                            .max_gas_unit_price
-                            .map(TryIntoConv::try_into_)
-                            .transpose()?,
-                    },
+                    (None, _, _) => {
+                        if let Some(max_gas) = self.max_gas {
+                            if max_gas == Felt::ZERO {
+                                bail!("--max-gas should be greater than 0")
+                            }
+                        }
+                        FeeSettings::Strk {
+                            max_gas: self.max_gas.map(TryIntoConv::try_into_).transpose()?,
+                            max_gas_unit_price: self
+                                .max_gas_unit_price
+                                .map(TryIntoConv::try_into_)
+                                .transpose()?,
+                        }
+                    }
                     (Some(max_fee), None, Some(max_gas_unit_price)) => FeeSettings::Strk {
                         max_gas: Some(
                             max_fee
@@ -106,29 +113,36 @@ impl FeeArgs {
                         ),
                         max_gas_unit_price: Some(max_gas_unit_price.try_into_()?),
                     },
-                    (Some(max_fee), Some(max_gas), None) => FeeSettings::Strk {
-                        max_gas: Some(max_gas.try_into_()?),
-                        max_gas_unit_price: Some(
-                            max_fee
-                                .floor_div(&NonZeroFelt::from_felt_unchecked(max_gas))
-                                .try_into_()?,
-                        ),
-                    },
+                    (Some(max_fee), Some(max_gas), None) => {
+                        let max_gas_unit_price =
+                            max_fee.floor_div(&NonZeroFelt::from_felt_unchecked(max_gas));
+                        if max_gas_unit_price == Felt::ZERO {
+                            bail!("--max-gas calculated from --max-fee should be greater than 0. Please increase --max-fee")
+                        }
+
+                        FeeSettings::Strk {
+                            max_gas: Some(max_gas.try_into_()?),
+                            max_gas_unit_price: Some(
+                                max_fee
+                                    .floor_div(&NonZeroFelt::from_felt_unchecked(max_gas))
+                                    .try_into_()?,
+                            ),
+                        }
+                    }
                     (Some(max_fee), None, None) => {
                         let max_gas_unit_price = provider
                             .get_block_with_tx_hashes(block_id)
                             .await?
                             .l1_gas_price()
                             .price_in_fri;
+                        let max_gas = max_fee
+                            .floor_div(&NonZeroFelt::from_felt_unchecked(max_gas_unit_price));
+                        if max_gas == Felt::ZERO {
+                            bail!("--max-gas calculated from --max-fee should be greater than 0. Please increase --max-fee")
+                        }
 
                         FeeSettings::Strk {
-                            max_gas: Some(
-                                max_fee
-                                    .floor_div(&NonZeroFelt::from_felt_unchecked(
-                                        max_gas_unit_price,
-                                    ))
-                                    .try_into_()?,
-                            ),
+                            max_gas: Some(max_gas.try_into_()?),
                             max_gas_unit_price: Some(max_gas_unit_price.try_into_()?),
                         }
                     }

crates/sncast/tests/e2e/invoke.rs

@@ -388,6 +388,78 @@ fn test_too_low_max_fee() {
     );
 }
 
+#[test]
+fn test_max_gas_equal_to_zero() {
+    let args = vec![
+        "--accounts-file",
+        ACCOUNT_FILE_PATH,
+        "--account",
+        "user11",
+        "--wait",
+        "invoke",
+        "--url",
+        URL,
+        "--contract-address",
+        MAP_CONTRACT_ADDRESS_SEPOLIA,
+        "--function",
+        "put",
+        "--calldata",
+        "0x1",
+        "0x2",
+        "--max-gas",
+        "0",
+        "--fee-token",
+        "strk",
+    ];
+
+    let snapbox = runner(&args);
+    let output = snapbox.assert().success();
+
+    assert_stderr_contains(
+        output,
+        indoc! {r"
+        command: invoke
+        error: --max-gas should be greater than 0
+        "},
+    );
+}
+
+#[test]
+fn test_max_gas_calculated_from_max_fee_equal_to_zero() {
+    let args = vec![
+        "--accounts-file",
+        ACCOUNT_FILE_PATH,
+        "--account",
+        "user11",
+        "--wait",
+        "invoke",
+        "--url",
+        URL,
+        "--contract-address",
+        MAP_CONTRACT_ADDRESS_SEPOLIA,
+        "--function",
+        "put",
+        "--calldata",
+        "0x1",
+        "0x2",
+        "--max-fee",
+        "0",
+        "--fee-token",
+        "strk",
+    ];
+
+    let snapbox = runner(&args);
+    let output = snapbox.assert().success();
+
+    assert_stderr_contains(
+        output,
+        indoc! {r"
+        command: invoke
+        error: --max-gas calculated from --max-fee should be greater than 0. Please increase --max-fee
+        "},
+    );
+}
+
 #[tokio::test]
 async fn test_happy_case_cairo_expression_calldata() {
     let tempdir = create_and_deploy_oz_account().await;