Refactor snforge_std - typed_checked_cheatcode
#2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkawula
changed the title
snforge_std - typed_checked_cheatcode
kkawula
requested review from
cptartur,
ddoktorski and
franciszekjob
as code owners
cptartur
reviewed
Jan 10, 2025
| } | ||
| } | ||
|
|
||
| pub(crate) fn typed_checked_cheatcode<const selector: felt252, T, +Serde<T>>( |
There was a problem hiding this comment.
Suggested change
| pub(crate) fn typed_checked_cheatcode<const selector: felt252, T, +Serde<T>>( | |
| pub(crate) fn typed_cheatcode<const selector: felt252, T, +Serde<T>>( |
| pub(crate) fn handle_cheatcode(input: Span<felt252>) -> Span<felt252> { | ||
| let first = *input.at(0); | ||
| let input = input.slice(1, input.len() - 1); | ||
| pub(crate) fn checked_cheatcode<const selector: felt252>(input: Span<felt252>) -> Span<felt252> { |
There was a problem hiding this comment.
Does this need to be pub at all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am happy to announce the first pr from our mailing list! 🔥🔥
Thanks Peter for your contribution
Introduced changes
Checklist
CHANGELOG.md