Introduce base_controller_class config option #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractaledmind
approved these changes
Oct 26, 2024
|
Excellent! In particular I wasn't sure if you'd prefer a method for reading this value, so let me know if you'd want that change. |
|
@fractaledmind are there any changes you'd like me to make on this? |
mactunechy
reviewed
Nov 20, 2024
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| module SolidErrors | |||
| mattr_accessor :connects_to | |||
| mattr_accessor :base_controller_class, default: "::ActionController::Base" | |||
There was a problem hiding this comment.
for consistency we can remove the default here and have it in a getter method as below:
Suggested change
| mattr_accessor :base_controller_class, default: "::ActionController::Base" | |
| mattr_accessor :base_controller_class |
|
|
||
| def test_default_base_controller | ||
| assert_equal ActionController::Base, SolidErrors::ApplicationController.superclass | ||
| end | ||
| end |
There was a problem hiding this comment.
Seems like we're only testing the default Superclass. we could also have test to assert that the custom configured controller is used as expected.
| @@ -21,8 +22,6 @@ def username | |||
| @username ||= ENV["SOLIDERRORS_USERNAME"] || @@username | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
def base_controller_class
@base_controller_class ||= @@base_controller_class || ::ActionController::Base
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It would be nice to use a specific controller from my application as the Solid Errors base controller, the same way that Mission Control Jobs does. For example, if
MyAdminControllerhandles all of my authentication, it would be nice to simply tell Solid Errors to inherit from that controller.Details:
This PR adds a new
base_controller_classconfig option to accomplish this.Please let me know if this is something you'd be willing to add, and if there any other aspects you'd like me to include or change.
And thank you for Solid Errors! Today I upgraded our production app to use Solid Errors ✌🏼