Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename strings.h -> string_utils.h #154

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

colugomusic
Copy link

This fixes #153

I can confirm that this resolves my build issue when using certain Boost libraries on Linux.

Maybe you'd prefer a different name than "string_utils", but since I had to make the change locally anyway to make progress on my project I thought I should submit the PR!

@frang75
Copy link
Owner

frang75 commented Oct 6, 2024

Hi @colugomusic. Thanks for share the change.
Unfortunately, since 2022, nappgui_src in GitHub is a read-only repository. All the changes have to be approved by NAppGUI CI/CD system. I will include your proposal ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strings.h should be renamed to avoid standard library conflicts.
2 participants