Update wagtail 6.3 #1161
Merged
Update wagtail 6.3 #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, update django-taggit, django-modelcluster and create migrations
chigby
requested changes
Jan 6, 2025
There was a problem hiding this comment.
I think this overall update is great. There's one small change I would add:
The release notes for wagtail 6.0 mention the Copy view being enabled by default. I think it's worth adding copy_view_enabled = False to ScanResultAdmin to avoid having the (broken) "Copy" action show up on the scan result list, as shown below.
requirements.txt
Outdated
| wagtail==5.2.6 \ | ||
| --hash=sha256:133ec00787d83ab7fa06255641aa855e7fd75f07d04af473bd98fe782c736595 \ | ||
| --hash=sha256:5497eecf8ffef7996e2ac348e90444deac71e54d3334eca27683c29da8754550 | ||
| wagtail==6.3.1 \ |
There was a problem hiding this comment.
We might as well make this wagtail 6.3.2, which is now released.
Comment on lines
35
to
36
| print(directories) | ||
| print(file_names) |
There was a problem hiding this comment.
Cleanup: print calls can be removed.
| local_storage = FileSystemStorage(os.path.join(fixtures_dir, "media")) | ||
| self._copy_files(local_storage, "") | ||
| call_command("loaddata", fixture_file, verbosity=4) | ||
| print(CustomImage.objects.all()) |
There was a problem hiding this comment.
Cleanup: print call can be removed.
|
@chigby addressed your comments. |
|
@SaptakS Did you see the mention of wagtail 6.3.2? |
|
Aah yes. Missed that. |
chigby
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1158 .
Changes proposed in this pull request:
Type of change
Testing
How should the reviewer test this PR?
Check that everything works without anything being broken.