Subordinate ids action buttons #652
Merged
+340
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carma12
force-pushed
the
subordinate-ids-action-buttons
branch
from
5b47ab1 to
85094d5
Compare
duzda
requested changes
Feb 28, 2025
The 'Add' button should generate a Subordinate ID for a given user. The addition has been handled via modal and the data has been filtered to show those users that don't have a SubID. On every generation, the data is refetch thus showing an updated version of the data. Signed-off-by: Carla Martinez <[email protected]>
carma12
force-pushed
the
subordinate-ids-action-buttons
branch
from
85094d5 to
598c6cd
Compare
Done. |
carma12
added
ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Add' button should generate a Subordinate ID for a given user.
The addition has been handled via modal and the data has been filtered to show those users that don't have a SubID. On every generation, the data is re-fetched, thus showing an updated version of the data.
This PR depends on this one to be merged: #651