Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lint warnings #520

Merged
merged 6 commits into from
Feb 25, 2025
Merged

fix: lint warnings #520

merged 6 commits into from
Feb 25, 2025

Conversation

AlanFnz
Copy link
Member

@AlanFnz AlanFnz commented Feb 24, 2025

What

This PR addresses and resolves the current warnings we are getting when running our linter

Why

Technical debt
​

How

It consists of:

  • Adding missing type annotations, mostly in stories
  • Removing unused imports
  • Removing alert from the experimental IconButton story in order to comply with the no-alert rule
  • Fix the placement property used in the Tooltip story
  • Use media query list obtained with evalColorSchemeQuery instead of the event's list in getCurrentScheme
    • This ensures the correct type (MediaQueryList) is passed and reflects the current state
  • Replace deprecated rules with their current equivalents in stylelint config

shiba-codes
shiba-codes approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@shiba-codes shiba-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🚀

@AlanFnz AlanFnz mentioned this pull request Feb 25, 2025
Open
@AlanFnz AlanFnz merged commit 08ea4b8 into main Feb 25, 2025
5 checks passed
@AlanFnz AlanFnz deleted the no_jira/fix-lint-warnings branch February 25, 2025 15:20
github-actions bot pushed a commit that referenced this pull request Feb 25, 2025
@semantic-release-bot
chore(release): 2.26.1 [skip ci]
7f0f390 
### [2.26.1](v2.26.0...v2.26.1) (2025-02-25)

### Bug Fixes

* lint warnings ([#520](#520)) ([08ea4b8](08ea4b8))
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 2.26.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiba-codes shiba-codes shiba-codes approved these changes

@jonotrujillo jonotrujillo Awaiting requested review from jonotrujillo jonotrujillo is a code owner

@dornelasnelson dornelasnelson Awaiting requested review from dornelasnelson dornelasnelson is a code owner

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlanFnz @shiba-codes