Go to page, vim style #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does it make sense to store the jumps, allowing the user to go back? |
I'm open to this. Double backtick seems to be the closest vi keybinding (when using : for changing pages). Looking at the code I think we're going to need some better logic/structures to handle leader keys properly. |
|
Closing in favor of #45 which continues this work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modification of #17 that uses vi style keys to change pages.
Type
:, enter a number, then press enter to jump to the page.There aren't really usage instructions yet so I just added a comment to the config for now.
The
is_changing_pageflag isn't strictly required for this change but I thought it would be good to keep in case more uses for number keys appear in the future.