-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More typical zooming effect #37
Conversation
works very well :) |
I implemented it like this at first, but the impact on performance is too big, any ideas? |
I think the impact on performance comes down to the number of pixels (resolution × size of page), so the impact is more pronounced when both the contents and the page are scaled even beyond the window’s boundaries without restricting the view. However, restricting the view, as in the proposed implementation, limits the impact. On my end, the proposed zooming implementation seems on par performance-wise with the current approach for the same window size. |
EDIT: I completely forgot that I was testing this over ssh. On my local system I also think the difference is negligible. Personally the better view is more important to me than the performance difference of getting there. If this is what the final product should look like I think we should keep that behavior and look for optimizations rather than change the final product for a workaround. |
For the minimum zoom: I was initially against zooming out beyond the initial size but I am happy with the min zoom config option. |
Just to add more details to this discussion: My initial strategy (not submitted here) was to scale the entire page with a rendered area ( However, what is submitted here adopts a different strategy: |
Closing in favor of #47 which continues this work |
This pull request implements a more typical zooming effect, addressing #36.
The implementation additionally fixes a crash that occurs when resizing the terminal window to a height of one cell.