Create Android workflows & refactor iOS KMP workflows #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
matejsemancik
commented
Dec 20, 2024
matejsemancik
commented
- Added new Android workflows
- Removed detect-changes from iOS KMP workflows as this step should be run in trigger workflow
|
@matejsemancik Matsem jak prosímtě budete řešit to detect changes? |
@jmarek41 Detect changes ostane v tomto repe ako reusable workflow a budeš si ho musieť volať v projekte z trigger workflow. |
jmarek41
reviewed
Jan 28, 2025
xmadera
reviewed
Jan 28, 2025
.github/workflows/android-cloud-release-firebaseAppDistribution.yml
Outdated
Show resolved
Hide resolved
xmadera
reviewed
Jan 29, 2025
.github/workflows/android-cloud-release-firebaseAppDistribution.yml
Outdated
Show resolved
Hide resolved
… defaults - Add default values for `VERSION_NAME` and `BUILD_NUMBER_OFFSET` inputs in the `android-cloud-release-firebaseAppDistribution.yml` workflow. - Make `BUILD_NUMBER_OFFSET` optional input and add default value in `android-cloud-release-googlePlay.yml` workflow. - Change `VERSION_NAME` description in `android-cloud-release-googlePlay.yml` from "Release version name" to "Build version name". - Improve descriptions for `SIGNING_KEYSTORE_PATH` and `GOOGLE_PLAY_WHATSNEW_DIRECTORY` inputs in `android-cloud-release-googlePlay.yml`. - Update `SECRET_PROPERTIES_FILE` description to clarify that it is picked up by the Secrets Gradle plugin in both workflows. - Rename `CUSTOM_SECRETS` input to `SECRET_PROPERTIES` and update description accordingly in both workflows. - Update `APP_DISTRIBUTION_SERVICE_ACCOUNT` and `GOOGLE_PLAY_PUBLISH_SERVICE_ACCOUNT` descriptions in both workflows.
jmarek41
approved these changes
Jan 29, 2025
xmadera
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Narazil jsem ještě na 2 body
- Release notes by mělo dát přidat i k firebase distribuci, ale ještě jsem nenarazil na projekt, kde by se to smysluplně využívalo, tak asi není třeba 😄
- Na některých projektech se teď začala využívat slack apka MasTuBuild, tam je potřeba přístup přímo k infu apk filu - otázka, zda to ještě vůbec budeme s firebasem potřebovat, když má notifikace s novým buildem defaultně 🤔 Asi to můžeme ještě otevřít na dalším An talku
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.