Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix races within flatpak portal dialogs #5394

Merged
merged 4 commits into from
Jan 11, 2025

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Jan 11, 2025

Description:

This cleans up and refactors the dialog code for desktop portals on flatpak and it does so while fixing some races in it. I also fixed RunNative not behaving correctly (or as expected) with the new threading model.

For #4654

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that, neater indeed :)

@Jacalz Jacalz merged commit b7b8a61 into fyne-io:develop Jan 11, 2025
12 checks passed
@Jacalz Jacalz deleted the flatpak-dialog-races branch January 11, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants