Skip to content

Commit

Permalink
add TODOs and some FIXME
Browse files Browse the repository at this point in the history
  • Loading branch information
leemaster committed Jul 18, 2021
1 parent 3daa9d6 commit e69193b
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
9 changes: 8 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,11 @@ TODO:

Here is a simple clearfy FS manual and introduce some confused concepts in FS not only Channel lifecycle and more.

TODO:
TODO:

## TODO List

1. When Inbound disconnected and how to recover the inbound connection state?
2. If sendmsg could recover the session
3. Wrap the fsctl commands in this package
4. Total callcenter example single node no cluster
4 changes: 3 additions & 1 deletion channel.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ func (channel *channel) replycmd(cmd string) (reply *Event, err error) {
}

// execute command sendmsg
// FIXME: https://freeswitch.org/confluence/display/FREESWITCH/mod_event_socket#mod_event_socket-3.9sendmsg
// FIX to the suitable pattern of this command
func (channel *channel) sendmsg(body, uuid string) (response *Event, err error) {
builder := strings.Builder{}
builder.WriteString("sendmsg")
Expand Down Expand Up @@ -166,7 +168,7 @@ func (channel *channel) filter(action string, events ...string) (err error) {
}

// execute the resume command
// TODO: should know when should recover the session in the listener strtuct
// TODO: should know when should recover the session in the listener strtuct
// should review the FS source code to figure out this fuck thing
func (channel *channel) resume() (err error) {
// in FS could set this session as LFLAG_RESUME
Expand Down
3 changes: 3 additions & 0 deletions connection.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,9 @@ func (c *connection) recv() (event *Event, err error) {
// disconnect-notice
event.Type = EslDisconnectedNotice
debug("receive the disconnected notice")
uuid := headers.Get("Controlled-Session-UUID")
// FIXME: maybe there need an error to identify this event
debugf("Session UUID socket Disconnected Notice %s", uuid)
}
case EslEventAuthRequest: goto redo // because the auth request will be none should ignore
}
Expand Down

0 comments on commit e69193b

Please sign in to comment.