Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spine en doc for using in code. #2496

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

johanzhu
Copy link
Contributor

@johanzhu johanzhu commented Jan 8, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

  • Documentation
    • Added comprehensive documentation for Galacean Spine runtime
    • Included installation instructions
    • Explained asset loading techniques
    • Detailed usage of SpineAnimationRenderer component
    • Provided code examples for animation control and advanced skeleton operations

Copy link

coderabbitai bot commented Jan 8, 2025

Walkthrough

This pull request introduces a comprehensive documentation chapter for the Galacean Spine runtime in the English documentation. The new section, titled "Using in Code", provides detailed guidance on installing the Spine runtime package, importing the SpineAnimationRenderer component, loading Spine animation assets, and utilizing runtime APIs. The documentation covers installation instructions, asset loading methods, animation control techniques, and advanced skeleton manipulation, offering developers a thorough reference for implementing Spine animations in their projects.

Changes

File Change Summary
docs/en/graphics/2D/spine/runtime.md Added new chapter "Using in Code" with comprehensive documentation on Spine runtime installation, asset loading, animation control, and advanced skeleton operations

Suggested labels

documentation

Suggested reviewers

  • cptbtptpbcptdtptp

Possibly related PRs

Poem

🐰 Spine animations dance and twirl,
Code and runtime now unfurl!
Renderer magic, assets bright,
Galacean's docs shine with delight!
A rabbit's guide to motion's art 🎬


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.57%. Comparing base (97ea5ae) to head (90b47aa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2496      +/-   ##
==========================================
+ Coverage   70.56%   70.57%   +0.01%     
==========================================
  Files         526      526              
  Lines       27627    27627              
  Branches     4161     4161              
==========================================
+ Hits        19495    19498       +3     
+ Misses       6573     6570       -3     
  Partials     1559     1559              
Flag Coverage Δ
unittests 70.57% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
docs/en/graphics/2D/spine/runtime.md (4)

83-87: Consider using code blocks for URL examples.

For better readability and consistency, consider wrapping the example URLs in a code block:

-<br>https://your.spineboy.json<br>https://your.spineboy.atlas<br>https://your.spineboy.png<br>
+```
+https://your.spineboy.json
+https://your.spineboy.atlas
+https://your.spineboy.png
+```
🧰 Tools
🪛 Markdownlint (0.37.0)

85-85: null
Bare URL used

(MD034, no-bare-urls)


85-85: null
Bare URL used

(MD034, no-bare-urls)


85-85: null
Bare URL used

(MD034, no-bare-urls)


102-103: Consider using code blocks for URL examples with query parameters.

For better readability and consistency, consider wrapping the example URLs in a code block:

-<br>https://your.spineboyjson?ext=.json<br>https://your.spineboyatlas?ext=.atlas<br>
+```
+https://your.spineboyjson?ext=.json
+https://your.spineboyatlas?ext=.atlas
+```
🧰 Tools
🪛 Markdownlint (0.37.0)

102-102: null
Bare URL used

(MD034, no-bare-urls)


102-102: null
Bare URL used

(MD034, no-bare-urls)


231-234: Improve bullet points formatting.

For better readability and consistency with markdown standards, consider reformatting the parameters list:

-  - `TrackIndex`: The track index of the animation.
-  - `animationName`: The name of the animation.
-  - `loop`: Whether to loop the animation.
+* `TrackIndex`: The track index of the animation
+* `animationName`: The name of the animation
+* `loop`: Whether to loop the animation
🧰 Tools
🪛 LanguageTool

[uncategorized] ~231-~231: Loose punctuation mark.
Context: ...ccepts three parameters: - TrackIndex: The track index of the animation. - `an...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~232-~232: Loose punctuation mark.
Context: ...ndex of the animation. - animationName: The name of the animation. - loop: Wh...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~233-~233: Loose punctuation mark.
Context: ...me: The name of the animation. - loop`: Whether to loop the animation. The las...

(UNLIKELY_OPENING_PUNCTUATION)


403-404: Use proper markdown headers instead of bold text.

For better document structure and consistency, replace bold text with proper markdown headers:

-**Skin Switching**
+### Skin Switching

-**Skin Mixing**
+### Skin Mixing

Also applies to: 421-422

🧰 Tools
🪛 Markdownlint (0.37.0)

403-403: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 97ea5ae and 90b47aa.

📒 Files selected for processing (1)
  • docs/en/graphics/2D/spine/runtime.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/en/graphics/2D/spine/runtime.md

[style] ~101-~101: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...lative to the atlas file's path.
- If the custom uploaded asset has no file e...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[uncategorized] ~231-~231: Loose punctuation mark.
Context: ...ccepts three parameters: - TrackIndex: The track index of the animation. - `an...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~232-~232: Loose punctuation mark.
Context: ...ndex of the animation. - animationName: The name of the animation. - loop: Wh...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~233-~233: Loose punctuation mark.
Context: ...me: The name of the animation. - loop`: Whether to loop the animation. The las...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~268-~268: Loose punctuation mark.
Context: ...accepts four parameters: - TrackIndex: The animation track. - animationName:...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~269-~269: Loose punctuation mark.
Context: ...: The animation track. - animationName: The name of the animation. - loop: Wh...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~270-~270: Loose punctuation mark.
Context: ...me: The name of the animation. - loop: Whether to loop the animation. - delay...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~271-~271: Loose punctuation mark.
Context: ...Whether to loop the animation. - delay: The delay time. The first three parame...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~302-~302: Loose punctuation mark.
Context: ...imation control, such as: - timeScale: Controls the playback speed of the anim...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~303-~303: Loose punctuation mark.
Context: ...eed of the animation. - animationStart: Controls the start time of the animatio...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~304-~304: Loose punctuation mark.
Context: ...e start time of the animation. - alpha: The blending coefficient for applying t...

(UNLIKELY_OPENING_PUNCTUATION)

🪛 Markdownlint (0.37.0)
docs/en/graphics/2D/spine/runtime.md

85-85: null
Bare URL used

(MD034, no-bare-urls)


85-85: null
Bare URL used

(MD034, no-bare-urls)


85-85: null
Bare URL used

(MD034, no-bare-urls)


102-102: null
Bare URL used

(MD034, no-bare-urls)


102-102: null
Bare URL used

(MD034, no-bare-urls)


403-403: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


421-421: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: build (22.x, windows-latest)
  • GitHub Check: build (22.x, macos-latest)
  • GitHub Check: e2e (22.x)
  • GitHub Check: build (22.x, ubuntu-latest)
  • GitHub Check: codecov
🔇 Additional comments (1)
docs/en/graphics/2D/spine/runtime.md (1)

1-448: Well-structured and comprehensive documentation!

The documentation provides a thorough guide to using the Galacean Spine runtime, with clear examples and explanations. The content progression from basic setup to advanced features is logical and easy to follow.

🧰 Tools
🪛 LanguageTool

[style] ~101-~101: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...lative to the atlas file's path.
- If the custom uploaded asset has no file e...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[uncategorized] ~231-~231: Loose punctuation mark.
Context: ...ccepts three parameters: - TrackIndex: The track index of the animation. - `an...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~232-~232: Loose punctuation mark.
Context: ...ndex of the animation. - animationName: The name of the animation. - loop: Wh...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~233-~233: Loose punctuation mark.
Context: ...me: The name of the animation. - loop`: Whether to loop the animation. The las...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~268-~268: Loose punctuation mark.
Context: ...accepts four parameters: - TrackIndex: The animation track. - animationName:...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~269-~269: Loose punctuation mark.
Context: ...: The animation track. - animationName: The name of the animation. - loop: Wh...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~270-~270: Loose punctuation mark.
Context: ...me: The name of the animation. - loop: Whether to loop the animation. - delay...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~271-~271: Loose punctuation mark.
Context: ...Whether to loop the animation. - delay: The delay time. The first three parame...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~302-~302: Loose punctuation mark.
Context: ...imation control, such as: - timeScale: Controls the playback speed of the anim...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~303-~303: Loose punctuation mark.
Context: ...eed of the animation. - animationStart: Controls the start time of the animatio...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~304-~304: Loose punctuation mark.
Context: ...e start time of the animation. - alpha: The blending coefficient for applying t...

(UNLIKELY_OPENING_PUNCTUATION)

🪛 Markdownlint (0.37.0)

85-85: null
Bare URL used

(MD034, no-bare-urls)


85-85: null
Bare URL used

(MD034, no-bare-urls)


85-85: null
Bare URL used

(MD034, no-bare-urls)


102-102: null
Bare URL used

(MD034, no-bare-urls)


102-102: null
Bare URL used

(MD034, no-bare-urls)


403-403: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


421-421: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants