Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support pbr sheen #692

Closed
wants to merge 16 commits into from
Closed

Conversation

zhuxudong
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature.

What is the current behavior? (You can also link to an open issue here)

no sheen radiance

What is the new behavior (if this is a feature change)?

image

@zhuxudong zhuxudong added the enhancement New feature or request label Mar 15, 2022
@zhuxudong zhuxudong added this to the 0.7 milestone Mar 15, 2022
@zhuxudong zhuxudong self-assigned this Mar 15, 2022
@zhuxudong zhuxudong linked an issue Mar 15, 2022 that may be closed by this pull request
@zhuxudong zhuxudong added the Rendering Rendering related functions label Mar 17, 2022
@GuoLei1990 GuoLei1990 changed the base branch from dev/0.7 to dev/0.8 May 6, 2022 02:49
@GuoLei1990 GuoLei1990 deleted the branch galacean:main August 4, 2022 06:48
@GuoLei1990 GuoLei1990 closed this Aug 4, 2022
@GuoLei1990 GuoLei1990 reopened this Aug 4, 2022
@GuoLei1990 GuoLei1990 changed the base branch from dev/0.8 to main August 4, 2022 08:38
@GuoLei1990 GuoLei1990 modified the milestones: 0.7, 1.0 Nov 14, 2022
@zhuxudong zhuxudong mentioned this pull request Sep 4, 2024
@GuoLei1990
Copy link
Member

Migrated to:envBRDFApprox_Sheen and galacean/engine-toolkit#312

@GuoLei1990 GuoLei1990 closed this Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 20.33898% with 94 lines in your changes missing coverage. Please review.

Project coverage is 44.29%. Comparing base (aca8331) to head (4cab9cb).
Report is 1548 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/material/PBRBaseMaterial.ts 17.80% 60 Missing ⚠️
...der/src/gltf/extensions/KHR_materials_clearcoat.ts 0.00% 17 Missing ⚠️
.../loader/src/gltf/extensions/KHR_materials_sheen.ts 0.00% 16 Missing ⚠️
.../extensions/KHR_materials_pbrSpecularGlossiness.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
- Coverage   48.09%   44.29%   -3.80%     
==========================================
  Files         349      410      +61     
  Lines       18979    21856    +2877     
  Branches     2547     2993     +446     
==========================================
+ Hits         9128     9682     +554     
- Misses       9851    12174    +2323     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Rendering Rendering related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PBR Material interface redesign
2 participants