Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support pbr ior #694

Closed
wants to merge 17 commits into from
Closed

Conversation

zhuxudong
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature.

What is the current behavior? (You can also link to an open issue here)

F0 = 0.04 in all of the dielectric materials.

What is the new behavior (if this is a feature change)?

support F0 = ( (ior - 1)/(ior + 1) )^2, and KHR_materials_ior

Other information:

image

@zhuxudong zhuxudong added the enhancement New feature or request label Mar 16, 2022
@zhuxudong zhuxudong added this to the 0.7 milestone Mar 16, 2022
@zhuxudong zhuxudong self-assigned this Mar 16, 2022
@zhuxudong zhuxudong linked an issue Mar 16, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev/0.7@5086d41). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             dev/0.7     #694   +/-   ##
==========================================
  Coverage           ?   43.89%           
==========================================
  Files              ?      409           
  Lines              ?    21554           
  Branches           ?     2980           
==========================================
  Hits               ?     9462           
  Misses             ?    12092           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5086d41...23bf458. Read the comment docs.

@zhuxudong zhuxudong added the Rendering Rendering related functions label Mar 17, 2022
@GuoLei1990 GuoLei1990 mentioned this pull request Apr 1, 2022
22 tasks
@GuoLei1990 GuoLei1990 changed the base branch from dev/0.7 to dev/0.8 May 6, 2022 02:49
@GuoLei1990 GuoLei1990 deleted the branch galacean:main August 4, 2022 06:48
@GuoLei1990 GuoLei1990 closed this Aug 4, 2022
@GuoLei1990 GuoLei1990 reopened this Aug 4, 2022
@GuoLei1990 GuoLei1990 changed the base branch from dev/0.8 to main August 4, 2022 08:38
@GuoLei1990 GuoLei1990 modified the milestones: 0.7, 1.0 Nov 14, 2022
@zhuxudong
Copy link
Member Author

#1487

@zhuxudong zhuxudong closed this Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Rendering Rendering related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PBR Material interface redesign
3 participants