Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support specular intensity and F0 color in dielectric material #697

Closed
wants to merge 18 commits into from

Conversation

zhuxudong
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature.

What is the current behavior? (You can also link to an open issue here)

KHR_materials_specular is not supported and F0 & F90 can't be modified in dielectric material.

What is the new behavior (if this is a feature change)?

Supported.

Other information:

image

@zhuxudong zhuxudong added the enhancement New feature or request label Mar 17, 2022
@zhuxudong zhuxudong added this to the 0.7 milestone Mar 17, 2022
@zhuxudong zhuxudong self-assigned this Mar 17, 2022
@zhuxudong zhuxudong linked an issue Mar 17, 2022 that may be closed by this pull request
@zhuxudong zhuxudong added the Rendering Rendering related functions label Mar 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Attention: Patch coverage is 16.18497% with 145 lines in your changes missing coverage. Please review.

Project coverage is 43.83%. Comparing base (aca8331) to head (4b0cd6a).
Report is 1801 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/material/PBRBaseMaterial.ts 17.80% 60 Missing ⚠️
packages/core/src/material/PBRMaterial.ts 14.28% 24 Missing ⚠️
...der/src/gltf/extensions/KHR_materials_clearcoat.ts 0.00% 17 Missing ⚠️
.../loader/src/gltf/extensions/KHR_materials_sheen.ts 0.00% 16 Missing ⚠️
...ader/src/gltf/extensions/KHR_materials_specular.ts 0.00% 15 Missing ⚠️
...es/loader/src/gltf/extensions/KHR_materials_ior.ts 0.00% 7 Missing ⚠️
packages/loader/src/gltf/parser/MaterialParser.ts 58.33% 5 Missing ⚠️
.../extensions/KHR_materials_pbrSpecularGlossiness.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
- Coverage   48.09%   43.83%   -4.27%     
==========================================
  Files         349      410      +61     
  Lines       18979    21605    +2626     
  Branches     2547     2991     +444     
==========================================
+ Hits         9128     9470     +342     
- Misses       9851    12135    +2284     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 changed the base branch from dev/0.7 to dev/0.8 May 6, 2022 02:50
@GuoLei1990 GuoLei1990 deleted the branch galacean:main August 4, 2022 06:48
@GuoLei1990 GuoLei1990 closed this Aug 4, 2022
@GuoLei1990 GuoLei1990 reopened this Aug 4, 2022
@GuoLei1990 GuoLei1990 changed the base branch from dev/0.8 to main August 4, 2022 08:39
@GuoLei1990 GuoLei1990 modified the milestones: 0.7, 1.0 Nov 14, 2022
@zhuxudong zhuxudong closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Rendering Rendering related functions
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

PBR Material interface redesign
3 participants