-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependency husky to v2.7.0 - autoclosed #16846
Conversation
@rarkins Any idea why these are getting autoclosed? |
@sidharthachatterjee it's because of this change you made: e7a5214 husky is found in |
@rarkins Oh, got it. Makes sense. I reverted that temporarily so prevent too many merge conflicts (from yarn.lock) for the initial batch! Will add that back after most of these are in |
You could also add a |
@rarkins I actually want no rate limit at all so I can get them all and batch merge! Haha Anyway I can fold all these updates into a single PR or PR per package whose |
Usually you wouldn't want to group them by package file because then you end up with mismatched/duplicated versions of many dependencies. e.g. you'd update package X inside one packages/* file but be left with the old version of X within all the others (until you merge their PRs). The one exception might be devDependencies inside the root |
BTW you can group however you want though, including grouping every update together (or all patches, all non-major, etc). It's a tradeoff though because as I mentioned, you increase the chance of one bad update causing the others to be unmergeable. |
@rarkins Yeah, that makes sense. I guess it's best to wait and do this incrementally then! Thank you again 💜 |
How would I group all patches and non major? One final question: #16840 mentions a rate limit. How do I get rid of it? And the Closed/Ignored section seems to be listing updates that are merged already? |
By default Renovate doesn't separate patch from minor (i.e. you won't get a separate PR for both patch and minor of the same package), so you probably want to keep that. Then the rule for grouping all non-major is this: {
"packageRules": [{
"updateTypes": ["minor"],
"groupName": "all non-major"
}]
}
Add
This can sometimes happen in large monorepos. If Renovate sees that a particular package has been updated before, it won't raise another PR if the version isn't greater than before. So if you added packages with old versions after the previous PR, you might end up in that situation (they need upgrading, but Renovate thinks it's already upgraded before). In this case tick the checkbox to override. |
@rarkins Okay, awesome. I've gone ahead and added a package rule that makes sense. And Will all these get auto closed and a new one opened? |
Any PRs that were raised without yarn.lock updates will be autoclosed or automatically recreated. But you can tick the checkbox for each to have them rebased/recreated. The master issue even lets you do that for all open PRs at once. |
It could still be an "old" run waiting to complete. Note: it will reset the master issue back to unchecked again when it's done, so you may need to check again. This is essentially a "race condition" with using Issues for this UI |
@rarkins Aha. That makes sense. Let's wait for a while then! Thank you so much once again for all you support 💜 You're incredible! |
This PR contains the following updates:
2.3.0
->2.7.0
Release Notes
typicode/husky
v2.7.0
Compare Source
Due to issues with Git
< 2.13.2
, this version is a rollback and is the same as huskyv2.4.1
. Changes introduced inv2.5.0
andv2.6.0
will be published inv3.0.0
.v2.6.0
Compare Source
HUSKY_USE_YARN
setting to use Yarn to run Husky<= 8.6.0
Deprecated
v2.5.0
Compare Source
CWD
in debug messagesDeprecated
v2.4.1
Compare Source
v2.4.0
Compare Source
HUSKY_SKIP_HOOKS
to skip all hooksRenovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!
".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.