chore: upgrade core-js to version 3 #25157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
commented
Jun 20, 2020
| @@ -46,7 +45,7 @@ if (semver.prerelease(version)) { | |||
| report.warn( | |||
| report.stripIndent(` | |||
| You are currently using a prerelease version of Node (${version}), which is not supported. | |||
| You can use this for testing, but we do not recommend it in production. | |||
| You can use this for testing, but we do not recommend it in production. | |||
wardpeet
commented
Jun 20, 2020
| @@ -11,7 +11,6 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@babel/code-frame": "^7.10.1", | |||
| "@babel/runtime": "^7.10.2", | |||
There was a problem hiding this comment.
It's unused but also not necessary
wardpeet
force-pushed
the
feat/core-js-resolver
branch
from
e9f83a3 to
de23ad0
Compare
pvdz
added
topic: webpack/babel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade babel-preset & gatsby to core-js 3. Core-js 2 has been deprecated for a while but we never had a good story to upgrade it. Now with the polyfill work we're doing we can.
I've added a core-js resolver to make sure packages that are still compiled with core-js@2 are still working. It also makes our bundles smaller when core-js@2 is used inside the site itself.
Documentation
Nope
Related Issues
Fixes #15601
Fixes #23254
Fixes #23254