Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/core js resolver #25596

Closed
wants to merge 3 commits into from
Closed

Feat/core js resolver #25596

wants to merge 3 commits into from

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Jul 8, 2020

Description

Upgrade babel-preset & gatsby to core-js 3. Core-js 2 has been deprecated for a while but we never had a good story to upgrade it. Now with the polyfill work we're doing we can.

I've added a core-js resolver to make sure packages that are still compiled with core-js@2 are still working. It also makes our bundles smaller when core-js@2 is used inside the site itself.

You can test this package by installing it like this

yarn add --registry=https://registry.wardpeet.dev gatsby@core-js

Documentation

Nope

Related Issues

Fixes #15601
Fixes #23254
Addresses #24859

@wardpeet wardpeet requested review from a team as code owners July 8, 2020 07:31
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 8, 2020
@gatsby-cloud-staging
Copy link

Your pull request can be previewed in Gatsby Cloud: https://build-753bac6d-b2d7-4a15-aaf2-28ce89c8c661.staging-previews.gtsb.io

@wardpeet wardpeet closed this Jul 8, 2020
@wardpeet wardpeet deleted the feat/core-js-resolver branch July 9, 2020 06:44
@sidharthachatterjee sidharthachatterjee removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Can't resolve" importing errors when using canvg Upgrade core-js package to version 3
2 participants