chore: wasm-bindgen and web-sys workspace deps
#145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friendlymatthew
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
Is there any reason you stick to a specific version of wasm-bindgen and web-sys? It is quite inconvenient because it can cause cargo to fail.
Off the top of my head, I don't remember a specific reason. But these changes LGTM.
Thank you for another contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In this PR, I updated workspace dependencies.
Is there any reason you stick to a specific version of
wasm-bindgenandweb-sys? It is quite inconvenient because it can causecargoto fail. For example:Also, I fixed the
ssr-democompilation.