Skip to content

Commit

Permalink
Add braces inside #define macro bodies
Browse files Browse the repository at this point in the history
  • Loading branch information
Rangi42 committed Jan 28, 2025
1 parent 4e44958 commit 79401cc
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 9 deletions.
3 changes: 2 additions & 1 deletion include/helpers.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ static inline void unreachable_() {
// `[[gnu::assume()]]` for GCC or compatible also has insufficient support (GCC 13+ only)
#define assume(x) \
do { \
if (!(x)) \
if (!(x)) { \
unreachable_(); \
} \
} while (0)
#endif
#else
Expand Down
3 changes: 2 additions & 1 deletion include/link/main.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,9 @@ extern bool disablePadding;
// Helper macro for printing verbose-mode messages
#define verbosePrint(...) \
do { \
if (beVerbose) \
if (beVerbose) { \
fprintf(stderr, __VA_ARGS__); \
} \
} while (0)

struct FileStackNode {
Expand Down
6 changes: 4 additions & 2 deletions src/fix/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,9 @@ static MbcType parseMBC(char const *name) {

#define tryReadSlice(expected) \
do { \
if (!readMBCSlice(ptr, expected)) \
if (!readMBCSlice(ptr, expected)) { \
return MBC_BAD; \
} \
} while (0)

switch (*ptr++) {
Expand Down Expand Up @@ -1313,8 +1314,9 @@ int main(int argc, char *argv[]) {
switch (*musl_optarg) {
#define OVERRIDE_SPEC(cur, bad, curFlag, badFlag) \
case STR(cur)[0]: \
if (fixSpec & badFlag) \
if (fixSpec & badFlag) { \
fprintf(stderr, "warning: '" STR(cur) "' overriding '" STR(bad) "' in fix spec\n"); \
} \
fixSpec = (fixSpec & ~badFlag) | curFlag; \
break
#define overrideSpecs(fix, fixFlag, trash, trashFlag) \
Expand Down
6 changes: 4 additions & 2 deletions src/link/output.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -347,12 +347,14 @@ static void writeSymBank(SortedSections const &bankSections, SectionType type, u
for (auto it = bankSections.zeroLenSections.begin(); \
it != bankSections.zeroLenSections.end(); \
it++) { \
for (Section const *sect = *it; sect; sect = sect->nextu.get()) \
for (Section const *sect = *it; sect; sect = sect->nextu.get()) { \
__VA_ARGS__ \
} \
} \
for (auto it = bankSections.sections.begin(); it != bankSections.sections.end(); it++) { \
for (Section const *sect = *it; sect; sect = sect->nextu.get()) \
for (Section const *sect = *it; sect; sect = sect->nextu.get()) { \
__VA_ARGS__ \
} \
} \
} while (0)

Expand Down
9 changes: 6 additions & 3 deletions src/link/sdas_obj.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -148,19 +148,21 @@ void sdobj_ReadFile(FileStackNode const &where, FILE *file, std::vector<Symbol>
#define getToken(ptr, ...) \
do { \
token = strtok((ptr), delim); \
if (!token) \
if (!token) { \
fatal(&where, lineNo, __VA_ARGS__); \
} \
} while (0)
#define expectEol(...) \
do { \
token = strtok(nullptr, delim); \
if (token) \
if (token) { \
fatal(&where, lineNo, __VA_ARGS__); \
} \
} while (0)
#define expectToken(expected, lineType) \
do { \
getToken(nullptr, "'%c' line is too short", (lineType)); \
if (strcasecmp(token, (expected)) != 0) \
if (strcasecmp(token, (expected)) != 0) { \
fatal( \
&where, \
lineNo, \
Expand All @@ -169,6 +171,7 @@ void sdobj_ReadFile(FileStackNode const &where, FILE *file, std::vector<Symbol>
(expected), \
token \
); \
} \
} while (0)

uint32_t lineNo = 0;
Expand Down

0 comments on commit 79401cc

Please sign in to comment.